Skip to content

Conversation

douglowder
Copy link
Contributor

Description

Remove the old TVOSExample, and generate TV tests from the up-to-date FabricExample.

This will ensure that TV compilation is tested against the latest packages, and eliminate the need to maintain an entire example project just for this test.

Changes

  • Remove the TVOSExample, which used outdated dependencies
  • Use scripts to modify the FabricExample project for the TV compilation workflow
  • Add a Detox compile script to build TV
  • Modify the TV compilation workflow appropriately

Checklist

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for contribution.

I'm not sure yet on whether we want to go into this direction or not.

I'll be back with some feedback when I make my mind up (🔜)

@douglowder
Copy link
Contributor Author

Hey! Thanks for contribution.

I'm not sure yet on whether we want to go into this direction or not.

I'll be back with some feedback when I make my mind up (🔜)

Thanks @kkafar ! If you prefer, I can just move the existing TVOSExample to current React Native TV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants